[webkit-reviews] review granted: [Bug 42052] [Cairo] Font fallback determination is very ineffecient : [Attachment 68472] Patch for this issue

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 42052: [Cairo] Font fallback determination is very ineffecient
https://bugs.webkit.org/show_bug.cgi?id=42052

Attachment 68472: Patch for this issue
https://bugs.webkit.org/attachment.cgi?id=68472&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68472&action=review

Makes sense to me.

> WebCore/platform/graphics/cairo/FontCacheFreeType.cpp:-50
> -
> -    // FIXME: This should not happen, apparently. We are null-checking
> -    // for now just to avoid crashing.

I'd keep this FIXME comment for now, till it's accurate to remove it, as
discussed on IRC.