[webkit-reviews] review denied: [Bug 45812] Filter builder should be able to follow the filter object dependencies : [Attachment 68673] patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 45812: Filter builder should be able to follow the filter object
dependencies
https://bugs.webkit.org/show_bug.cgi?id=45812

Attachment 68673: patch
https://bugs.webkit.org/attachment.cgi?id=68673&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68673&action=review

Otherwise looks great!

> WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:82
> +    m_effectReferences.add(effect, FilterEffectSet());
> +
> +    FilterEffectVector& inputEffects = effect->inputEffects();
> +    int size = inputEffects.size();
> +
> +    // It is not possible to add the same value to a set twice.
> +    for (int i = 0; i < size; ++i)
> +	   getEffectReferences(effect.get()).add(inputEffects[i].get());

Please use numberOfInputEffects and inputEffect(unsigned) instead of the
EffectVector. Store the pointer effect.get() in a own variable.

> WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:90
> +    addBuiltinEffects();

Please remove this from clearEffects().