[webkit-reviews] review canceled: [Bug 45381] [Gtk] Adjust atk_text_get_text_at_offset to account for bullets/numbers in list items : [Attachment 68509] Patch proposal + unit tes updated

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has canceled Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 45381: [Gtk] Adjust atk_text_get_text_at_offset to account for
bullets/numbers in list items
https://bugs.webkit.org/show_bug.cgi?id=45381

Attachment 68509: Patch proposal + unit tes updated
https://bugs.webkit.org/attachment.cgi?id=68509&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #11)
> (In reply to comment #10)
> > [...]
> > Well, the goal is (of course) to present to the user what's on the screen.
And what's visually
> > on the screen looks like "1. item content here". The fact that this
appearance was achieved 
> > by rendering magic other than the addition of an actual space character is,
as far as the end 
> > user is concerned, irrelevant. Thus I'm afraid we do need the space added.
> 
> Ok. Then I'll try to come up with a patch dealing with that extra space. I've
just checked what firefox does in thit case and it seems they also add that
extra space, so let's follow the ff lead.
> 
> Thanks for the feedback.

Attaching a new patch that also returns the extra space, when needed, along
with the marker's suffix, so calling to RenderListMarker::suffix() returns the
same string that is going to be rendered when painting between the list item
and the item's content.

Hence, asking for review over this new patch.