[webkit-reviews] review denied: [Bug 46408] Add C API to WebKit2 for changing the font families : [Attachment 68595] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 46408: Add C API to WebKit2 for changing the font families
https://bugs.webkit.org/show_bug.cgi?id=46408

Attachment 68595: Patch
https://bugs.webkit.org/attachment.cgi?id=68595&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68595&action=review

> WebKit2/UIProcess/API/C/WKPreferences.cpp:160
> +void WKPreferencesSetStandardFontFamily(WKPreferencesRef preferencesRef,
WKStringRef family)
> +{
> +    toWK(preferencesRef)->setStandardFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WebPreferencesGetStandardFontFamily(WKPreferencesRef
preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->standardFontFamily());
> +}
> +
> +void WKPreferencesSetFixedFontFamily(WKPreferencesRef preferencesRef,
WKStringRef family)
> +{
> +    toWK(preferencesRef)->setFixedFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetFixedFontFamily(WKPreferencesRef preferencesRef)

> +{
> +    return toCopiedRef(toWK(preferencesRef)->fixedFontFamily());
> +}
> +
> +void WKPreferencesSetSerifFontFamily(WKPreferencesRef preferencesRef,
WKStringRef family)
> +{
> +    toWK(preferencesRef)->setSerifFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetSerifFontFamily(WKPreferencesRef preferencesRef)

> +{
> +    return toCopiedRef(toWK(preferencesRef)->serifFontFamily());
> +}
> +
> +void WKPreferencesSetSansSerifFontFamily(WKPreferencesRef preferencesRef,
WKStringRef family)
> +{
> +    toWK(preferencesRef)->setSansSerifFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetSansSerifFontFamily(WKPreferencesRef
preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->sansSerifFontFamily());
> +}
> +
> +void WKPreferencesSetCursiveFontFamily(WKPreferencesRef preferencesRef,
WKStringRef family)
> +{
> +    toWK(preferencesRef)->setCursiveFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetCursiveFontFamily(WKPreferencesRef
preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->cursiveFontFamily());
> +}
> +
> +void WKPreferencesSetFantasyFontFamily(WKPreferencesRef preferencesRef,
WKStringRef family)
> +{
> +    toWK(preferencesRef)->setFantasyFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetFantasyFontFamily(WKPreferencesRef
preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->fantasyFontFamily());
> +}

Since all the getters here return copied strings, these need to have the word
copy in them instead of get.