[webkit-reviews] review requested: [Bug 46336] Make Document::nodesFromRect more flexible : [Attachment 68644] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 23 21:53:22 PDT 2010


Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 46336: Make Document::nodesFromRect more flexible
https://bugs.webkit.org/show_bug.cgi?id=46336

Attachment 68644: patch v1
https://bugs.webkit.org/attachment.cgi?id=68644&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Summary

1) Patch changes Document::nodesFromRect API from
 
 - RefPtf<NodeList> nodesFromRect(int x,
								  int y, 
								  unsigned
horizontalPadding, 
								  unsigned
verticalPadding,
								  bool
ignoreClipping)
 to
 
 - RefPtf<NodeList> nodesFromRect(int x, int y,
								  unsigned
topPadding,
								  unsigned
rightPadding,
								  unsigned
bottomPadding,
								  unsigned
leftPadding,
								  bool
ignoreClipping)
 
2) Patch adjust WebCore related classes accordingly to support this, incluing
HitTestResult, RenderLayer, etc.
3) Fixes the layout test accordingly to the proposed API change.


More information about the webkit-reviews mailing list