[webkit-reviews] review granted: [Bug 45416] Allow Chromium port to link with system-provided SQLite : [Attachment 68364] patch

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has granted Paweł Hajdan, Jr.
<phajdan.jr at chromium.org>'s request for review:
Bug 45416: Allow Chromium port to link with system-provided SQLite
https://bugs.webkit.org/show_bug.cgi?id=45416

Attachment 68364: patch
https://bugs.webkit.org/attachment.cgi?id=68364&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68364&action=review

r=me, but please patch this change into chromium __on linux and mac__, and make
sure all LayoutTests/storage tests pass before you submit it. if you're not a
webkit committer, please address my comment and upload a new patch, and i'll
r+/cq+ it.

> WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:756
> +    bool success = false;
> +    if (fullSync)
> +	   success = !fcntl(fd, F_FULLSYNC, 0);
> +    if (!success)
> +	   success = !fsync(fd);

missing return statement for PLATFORM(MAC). please test the patch on both linux
and mac.