[webkit-reviews] review canceled: [Bug 46332] rebaseline-chromium-webkit-tests crashes in a symlinked Git checkout : [Attachment 68623] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has canceled Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 46332: rebaseline-chromium-webkit-tests crashes in a symlinked Git checkout
https://bugs.webkit.org/show_bug.cgi?id=46332

Attachment 68623: Patch
https://bugs.webkit.org/attachment.cgi?id=68623&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68623&action=review

This looks great.  I'd love to r+ it, but we'd like to see tests here.

> WebKitTools/ChangeLog:10
> +	   Note: this patch has not been tested yet, since the unit tests fail.

> +	   I am posting it for preliminary review accordingly.

Yeah, we'd like to test this patch.

> WebKitTools/Scripts/webkitpy/common/checkout/scm.py:636
> +	   # normalize to the checkout dir

I'd skip this comment since we do this all over now.

> WebKitTools/Scripts/webkitpy/common/checkout/scm.py:736
> +	   self.run(['git', 'checkout', 'HEAD'] + [self.relative_path(p) for p
in file_paths])

Maybe use map here?