[webkit-reviews] review granted: [Bug 46425] Add PluginProcessConnection and PluginProcessConnectionManager : [Attachment 68615] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 46425: Add PluginProcessConnection and PluginProcessConnectionManager
https://bugs.webkit.org/show_bug.cgi?id=46425

Attachment 68615: Patch
https://bugs.webkit.org/attachment.cgi?id=68615&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68615&action=review

> WebKit2/WebProcess/Plugins/PluginProcessConnection.h:67
> +    // The CoreIPC connection.

I don't think this comment is adding anything.

> WebKit2/WebProcess/Plugins/PluginProcessConnectionManager.cpp:73
> +    }
> +
> +    CoreIPC::Connection::Identifier connectionIdentifier;
> +    CoreIPC::MachPort connectionMachPort;
> +    if
(!WebProcess::shared().connection()->sendSync(WebProcessProxyMessage::GetPlugin
ProcessConnection, 0,
> +						       
CoreIPC::In(pluginPath),
> +						       
CoreIPC::Out(connectionMachPort),
> +						       
CoreIPC::Connection::NoTimeout))
> +	   return 0;
> +
> +    connectionIdentifier = connectionMachPort.port();
> +    if (!connectionIdentifier)
> +	   return 0;
> +

This looks very mac specific.  Should it be in a mac specific directory?


Otherwise looks good.