[webkit-reviews] review denied: [Bug 45722] Lower the default canvas interpolation quality for platforms that use CG : [Attachment 68584] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 45722: Lower the default canvas interpolation quality for platforms that
use CG
https://bugs.webkit.org/show_bug.cgi?id=45722

Attachment 68584: Patch
https://bugs.webkit.org/attachment.cgi?id=68584&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68584&action=review

> WebCore/html/canvas/CanvasRenderingContext2D.cpp:140
> +    if (GraphicsContext* c = drawingContext())
> +	   c->setImageInterpolationQuality(DefaultInterpolationQuality);

We deliberately delayed creation of the underlying ImageBuffer in the canvas so
that we don't end up doing a whole lot of work on an imagebuffer that is going
to be thrown out.  Also this means when we do throw out the buffer and then
recreate it we won't reset the interpolation quality.

The existing location of the call to setInterpolation quality is the correct
one.