[webkit-reviews] review granted: [Bug 45808] Add Worker support for FileSystem API : [Attachment 68610] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 23 15:56:23 PDT 2010
David Levin <levin at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 45808: Add Worker support for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=45808
Attachment 68610: Patch
https://bugs.webkit.org/attachment.cgi?id=68610&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68610&action=review
Two trivial suggestions.
> WebCore/workers/WorkerContext.h:157
> + void registerObserver(Observer* observer);
> + void unregisterObserver(Observer* observer);
Remove param name "observer".
> WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h:107
> + // m_selfRef keeps a reference to itself until tasks are created for the
worker thread (at which point the tasks hold the reference).
My typo s/tasks/task/
More information about the webkit-reviews
mailing list