[webkit-reviews] review denied: [Bug 46385] Keep viewport information in Document : [Attachment 68593] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 23 15:05:00 PDT 2010
Daniel Bates <dbates at webkit.org> has denied review:
Bug 46385: Keep viewport information in Document
https://bugs.webkit.org/show_bug.cgi?id=46385
Attachment 68593: patch
https://bugs.webkit.org/attachment.cgi?id=68593&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68593&action=review
> WebCore/dom/Document.cpp:3813
> + if (!frame() || !frame()->page())
> +
frame()->page()->chrome()->client()->didReceiveViewportArguments(frame(),
m_viewportArguments);
This doesn't look correct. Why are you calling frame() if it's a null pointer?
Similarly, if frame()->page() is null.
More information about the webkit-reviews
mailing list