[webkit-reviews] review granted: [Bug 46385] Keep viewport information in Document : [Attachment 68593] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 23 14:42:36 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Luiz Agostini
<luiz at webkit.org>'s request for review:
Bug 46385: Keep viewport information in Document
https://bugs.webkit.org/show_bug.cgi?id=46385

Attachment 68593: patch
https://bugs.webkit.org/attachment.cgi?id=68593&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68593&action=review

LGTM, r=me

> WebKit/qt/Api/qwebframe.cpp:235
> +    if (!frame || !frame->document())

Don't you always have a frame here?


More information about the webkit-reviews mailing list