[webkit-reviews] review denied: [Bug 46390] Remove unnecessary parameter from AsyncFileWriterClient::didTruncate : [Attachment 68582] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 23 14:39:30 PDT 2010


David Levin <levin at chromium.org> has denied Eric U. <ericu at chromium.org>'s
request for review:
Bug 46390: Remove unnecessary parameter from AsyncFileWriterClient::didTruncate
https://bugs.webkit.org/show_bug.cgi?id=46390

Attachment 68582: Patch
https://bugs.webkit.org/attachment.cgi?id=68582&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68582&action=review

Just a few things to address.

> WebCore/fileapi/FileWriter.cpp:@
>  void FileWriter::truncate(long long posi

Please init m_truncateLength to 0 in constructor.

> WebCore/fileapi/FileWriter.cpp:174
> +    ASSERT(m_truncateLength >= 0);

Why are there both of these asserts?
Should they also be in FileWriter::truncate when m_truncateLength is set?

> WebCore/fileapi/FileWriter.cpp:178
>      m_readyState = DONE;

Set m_truncateLength be set back to 0 here.

> WebKit/chromium/src/AsyncFileWriterChromium.h:-64
> -    virtual void didTruncate(long long length);

What code calls this api? (I don't see a change to it.)


More information about the webkit-reviews mailing list