[webkit-reviews] review granted: [Bug 46326] Crash when trying to create a NodeIterator rooted at a document-less DocumentType node : [Attachment 68577] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 46326: Crash when trying to create a NodeIterator rooted at a document-less
DocumentType node
https://bugs.webkit.org/show_bug.cgi?id=46326

Attachment 68577: proposed fix
https://bugs.webkit.org/attachment.cgi?id=68577&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68577&action=review

Since you’re a committer I’ll let you set the commit-queue flag yourself if you
decide you don’t want to fix the minor typos and such I mentioned above.

> WebCore/ChangeLog:11
> +	   attach/detach may not be always paired.

Tiny grammatical nitpick: "may not always be paired" is better phrasing.

> WebCore/dom/Document.cpp:3217
> +    // The node iterator can be detached wihtout having been atatched if its
root node didn't have a document

Typo: "wihtout".
Typo: "atatched".

> LayoutTests/fast/dom/node-iterator-with-doctype-root.html:31
> +iter

Did you put this line in intentionally? If so, what purpose does it serve?
Would a comment make that clearer? Would some logging after the fact be
helpful?