[webkit-reviews] review denied: [Bug 46344] Update DeviceMotionEvent to spec : [Attachment 68567] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 46344: Update DeviceMotionEvent to spec
https://bugs.webkit.org/show_bug.cgi?id=46344

Attachment 68567: Patch
https://bugs.webkit.org/attachment.cgi?id=68567&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68567&action=review

> WebCore/dom/DeviceMotionData.h:101
> +    PassRefPtr<Acceleration> acceleration() const { return m_acceleration; }

> +    PassRefPtr<Acceleration> accelerationIncludingGravity() const { return
m_accelerationIncludingGravity; }
> +    PassRefPtr<RotationRate> rotationRate() const { return m_rotationRate; }


These should not return PassRefPtr<Acceleration>; that implies transfer of
ownership. You should return raw const pointers here.

Sorry i missed this last time.