[webkit-reviews] review granted: [Bug 46383] Fix ResourceHandleWin::cancel() for network resources : [Attachment 68558] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 23 12:22:14 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 46383: Fix ResourceHandleWin::cancel() for network resources
https://bugs.webkit.org/show_bug.cgi?id=46383

Attachment 68558: Patch
https://bugs.webkit.org/attachment.cgi?id=68558&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68558&action=review

> WebCore/platform/network/win/ResourceHandleWin.cpp:561
> +    if (d->m_requestHandle) {
> +	   d->m_internetHandle = 0;
> +	   InternetCloseHandle(d->m_requestHandle);
> +	   InternetCloseHandle(d->m_connectHandle);
> +    } else

Do we need to clear out d->m_requestHandle, too?


More information about the webkit-reviews mailing list