[webkit-reviews] review denied: [Bug 46355] Fix usage of enum as if it was a define : [Attachment 68522] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 23 11:41:09 PDT 2010


Darin Adler <darin at apple.com> has denied Lucas De Marchi
<demarchi at webkit.org>'s request for review:
Bug 46355: Fix usage of enum as if it was a define
https://bugs.webkit.org/show_bug.cgi?id=46355

Attachment 68522: Patch
https://bugs.webkit.org/attachment.cgi?id=68522&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I am not sure we need two code paths here. The person who originally made this
patch was trying to preserve the faster simpler code path for platforms like
Mac OS X where the default for a mutex is a normal mutex, but I think we can
take the extra hit of always calling pthread_mutexattr_init on all platforms.
So lets just get rid of the #if and keep only the #else part.

Unless someone has evidence that the code is too slow when written that way.


More information about the webkit-reviews mailing list