[webkit-reviews] review granted: [Bug 45694] 'seeking' event should always fire : [Attachment 67449] Proposed patch.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 45694: 'seeking' event should always fire
https://bugs.webkit.org/show_bug.cgi?id=45694

Attachment 67449: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=67449&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=67449&action=review

> WebCore/ChangeLog:6
> +	   'seeking' event should always fire
> +	   https://bugs.webkit.org/show_bug.cgi?id=45694

Is this just a change to the spec that we're following? If so, the changelog
should say.

> WebCore/html/HTMLMediaElement.cpp:1099
> +    // 2 - If the element's seeking IDL attribute is true, then another
instance of this algorithm is
> +    // already running. Abort that other instance of the algorithm without
waiting for the step that
> +    // it is running to complete.

I don't understand how "another instance of the algorithm" can be running on
the same element. Can the comment clarify this?