[webkit-reviews] review granted: [Bug 46364] Add synchronous loading for network resources to ResourceHandleWin : [Attachment 68534] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 46364: Add synchronous loading for network resources to ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46364

Attachment 68534: Patch
https://bugs.webkit.org/attachment.cgi?id=68534&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68534&action=review

> WebCore/platform/network/win/ResourceHandleWin.cpp:504
> +    if (d->m_loadSynchronously)
> +	   while (onRequestComplete()) {
> +	       // Loop until finished.
> +	   }
> +

I would have expected onRequestComplete to return false when the request is not
complete, and true when it is complete.