[webkit-reviews] review granted: [Bug 46368] It should be possible to conditionally define an entire group of messages : [Attachment 68539] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 23 10:23:02 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 46368: It should be possible to conditionally define an entire group of
messages
https://bugs.webkit.org/show_bug.cgi?id=46368

Attachment 68539: Patch
https://bugs.webkit.org/attachment.cgi?id=68539&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
You should test that the condition makes it into the output files, too, not
just that we parse it correctly. ReceiverImplementationTest already does some
things like that.


More information about the webkit-reviews mailing list