[webkit-reviews] review granted: [Bug 46312] Skia's safeRef() and safeUnref() functions are undefined on NULL pointers. : [Attachment 68470] grep missed saveRef, fixed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 23 07:53:16 PDT 2010


David Levin <levin at chromium.org> has granted Steve VanDeBogart
<vandebo at chromium.org>'s request for review:
Bug 46312: Skia's safeRef() and safeUnref() functions are undefined on NULL
pointers.
https://bugs.webkit.org/show_bug.cgi?id=46312

Attachment 68470: grep missed saveRef, fixed.
https://bugs.webkit.org/attachment.cgi?id=68470&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68470&action=review

> WebCore/platform/graphics/skia/PlatformContextSkia.cpp:165
> +    // Up the ref count of these. SkSafeRef does nothing if its argument is
NULL.

Use 0 instead of NULL.


More information about the webkit-reviews mailing list