[webkit-reviews] review denied: [Bug 44700] IDBObjectStore::get should run in a transaction. : [Attachment 68476] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Andrei Popescu
<andreip at google.com>'s request for review:
Bug 44700: IDBObjectStore::get should run in a transaction.
https://bugs.webkit.org/show_bug.cgi?id=44700

Attachment 68476: Patch
https://bugs.webkit.org/attachment.cgi?id=68476&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68476&action=review

few comments until you can get me the re-based version with the test
changes....close tho

> WebCore/storage/IDBObjectStoreBackendImpl.h:76
> +    template <class T, class Method, class Param1, class Param2>

Could this stuff just all go in the .cpp?

> WebCore/storage/IDBTransactionCoordinator.h:70
> +    HashMap<int, RefPtr<IDBTransactionBackendImpl> > m_transactions;

This is a little be weird, but probably cleaner than anything else I can think
of (like having transactions self ref).

> WebCore/storage/IDBTransactionCoordinator.h:72
> +    HashSet<IDBTransactionBackendImpl*> m_pendingTransactions;

Is this still necessary?