[webkit-reviews] review granted: [Bug 45599] [Cairo] Generalize ContextShadow from the Qt port and use it for shadow code : [Attachment 68401] Patch with Dirk's suggestions

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 45599: [Cairo] Generalize ContextShadow from the Qt port and use it for
shadow code
https://bugs.webkit.org/show_bug.cgi?id=45599

Attachment 68401: Patch with Dirk's suggestions
https://bugs.webkit.org/attachment.cgi?id=68401&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68401&action=review

Nice stuff :)

> WebCore/platform/graphics/ContextShadow.h:113
> +    void calculateMinimalLayerRect(const FloatRect& layerArea, const
IntRect& clipRect);

I guess 'calculateLayerBoundingRect' is less complicated. 'Minimal' there does
not add anything.


Otherwise, LGTM.