[webkit-reviews] review granted: [Bug 46333] commit-queue should log more detailed messages to the QueueStatusServer : [Attachment 68493] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 46333: commit-queue should log more detailed messages to the
QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=46333

Attachment 68493: Patch
https://bugs.webkit.org/attachment.cgi?id=68493&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68493&action=review

Looks OK.

> WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:71
> +	   "Applied path",

patch?

> WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:122
> +	   "Unable to pass tests without patch")

Sounds like it might pass fine with it... but don't you dare take the patch
away! :p

We could have it include the revision number in these messages.  But that may
be a separate patch.