[webkit-reviews] review denied: [Bug 46331] minor cleanup of rebaseline-chromium-webkit-tests and gpu test_expectations : [Attachment 68491] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 22 19:49:08 PDT 2010
Adam Barth <abarth at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 46331: minor cleanup of rebaseline-chromium-webkit-tests and gpu
test_expectations
https://bugs.webkit.org/show_bug.cgi?id=46331
Attachment 68491: Patch
https://bugs.webkit.org/attachment.cgi?id=68491&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68491&action=review
This seems like patches. I'd just landed the test_expectation.txt part without
review.
> WebKitTools/ChangeLog:7
> + the tool to breat on a git checkout, but that needs to be tracked
breat => break
>
WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:5
92
> - # self._scm.add(path)
> + self._scm.add(path)
Seems like we need a test for whatever this does.
More information about the webkit-reviews
mailing list