[webkit-reviews] review granted: [Bug 42909] REGRESSION (r61285): <script /> parses differently in HTML5 : [Attachment 68484] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 42909: REGRESSION (r61285): <script /> parses differently in HTML5
https://bugs.webkit.org/show_bug.cgi?id=42909

Attachment 68484: Patch
https://bugs.webkit.org/attachment.cgi?id=68484&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68484&action=review

>> WebCore/html/parser/HTMLTreeBuilder.cpp:2220
>> +		}
> 
> I would write this as:
> 
>     ASSERT(m_tokenizer->state() == HTMLTokenizer::DataState ||
m_usePreHTML5ParserQuirks);
>     m_tokenizer->setState(HTMLTokenizer::DataState);
> 
> Also, I’d try to keep the comment shorter.

Yep.

> WebCore/html/parser/HTMLTreeBuilder.cpp:2724
> +	   if (m_usePreHTML5ParserQuirks && token.selfClosing())
> +	       processFakeEndTag(scriptTag);

Beautiful.