[webkit-reviews] review granted: [Bug 46316] patch for FreeBSD support with Chromium : [Attachment 68464] WebCore patch for FreeBSD

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 22 16:06:09 PDT 2010


Tony Chang <tony at chromium.org> has granted  review:
Bug 46316: patch for FreeBSD support with Chromium
https://bugs.webkit.org/show_bug.cgi?id=46316

Attachment 68464: WebCore patch for FreeBSD
https://bugs.webkit.org/attachment.cgi?id=68464&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68464&action=review

> platform/Scrollbar.cpp:43
> -#if PLATFORM(CHROMIUM) && OS(LINUX) || PLATFORM(GTK)
> +#if PLATFORM(CHROMIUM) && (OS(LINUX) || OS(FREEBSD)) || PLATFORM(GTK)

Nit: Can you add () around (PLATFORM(CHROMIUM) && (OS(LINUX) || OS(FREEBSD)))
so the order is clear?


More information about the webkit-reviews mailing list