[webkit-reviews] review granted: [Bug 46312] Skia's safeRef() and safeUnref() functions are undefined on NULL pointers. : [Attachment 68450] Use SkSafeRef/Unref instead of safeRef/Unref

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 22 15:55:43 PDT 2010


David Levin <levin at chromium.org> has granted Steve VanDeBogart
<vandebo at chromium.org>'s request for review:
Bug 46312: Skia's safeRef() and safeUnref() functions are undefined on NULL
pointers.
https://bugs.webkit.org/show_bug.cgi?id=46312

Attachment 68450: Use SkSafeRef/Unref instead of safeRef/Unref
https://bugs.webkit.org/attachment.cgi?id=68450&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68450&action=review

> WebCore/platform/graphics/skia/PlatformContextSkia.cpp:165
>      // Up the ref count of these. saveRef does nothing if 'this' is NULL.

This comment is incorrect. Please update.


More information about the webkit-reviews mailing list