[webkit-reviews] review granted: [Bug 46189] WebKit r67838 - Enabling Facebook chat would hang the browser : [Attachment 68457] Patch to properly handle transition between non-looping and looping alternatives.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 22 15:45:46 PDT 2010


Gavin Barraclough <barraclough at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 46189: WebKit r67838 - Enabling Facebook chat would hang the browser
https://bugs.webkit.org/show_bug.cgi?id=46189

Attachment 68457: Patch to properly handle transition between non-looping and
looping alternatives.
https://bugs.webkit.org/attachment.cgi?id=68457&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68457&action=review

> JavaScriptCore/yarr/RegexJIT.cpp:1320
> +			   // If we get here, there the last input checked
failed.

Typo, 'then' instead of 'there'?
r+ with a fix for the typo.


More information about the webkit-reviews mailing list