[webkit-reviews] review denied: [Bug 46303] [WinCairo] Update WebKitTestRunner and DumpRenderTree Build : [Attachment 68444] Build fixes for WinCairo.

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 46303: [WinCairo] Update WebKitTestRunner and DumpRenderTree Build
https://bugs.webkit.org/show_bug.cgi?id=46303

Attachment 68444: Build fixes for WinCairo.
https://bugs.webkit.org/attachment.cgi?id=68444&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68444&action=review

You seem to be missing a WebKit/ChangeLog entry.

> WebKitTools/WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:24
> +	<Tool
> +		Name="VCCLCompilerTool"
> +	       
AdditionalIncludeDirectories="&quot;$(ProjectDir)\..&quot;;&quot;$(ProjectDir)\
..\InjectedBundle\&quot;;&quot;$(ProjectDir)\..\InjectedBundle\Bindings&quot;;&
quot;$(WebKitOutputDir)\Include&quot;;&quot;$(WebKitOutputDir)\Include\private&
quot;;&quot;$(WebKitOutputDir)\Include\WebCore\ForwardingHeaders&quot;;&quot;$(
WebKitLibrariesDir)\include&quot;;&quot;$(WebKitOutputDir)\obj\InjectedBundle\D
erivedSources\&quot;"
> +		ForcedIncludeFiles="WebKitTestRunnerPrefix.h"
> +	/>
> +	<Tool
> +		Name="VCLinkerTool"
> +	       
AdditionalDependencies="JavaScriptCore$(WebKitDLLConfigSuffix).lib
WebKit$(WebKitDLLConfigSuffix).lib CFLite$(LibraryConfigSuffix).lib"
> +		OutputFile="$(OutDir)\$(ProjectName)$(WebKitConfigSuffix).dll"
> +	/>
> +	<Tool
> +		Name="VCPostBuildEventTool"
> +		CommandLine="if exist
&quot;$(WebKitOutputDir)\buildfailed&quot; del
&quot;$(WebKitOutputDir)\buildfailed&quot;"
> +	/>
> +	<Tool
> +		Name="VCPreBuildEventTool"
> +		CommandLine="%SystemDrive%\cygwin\bin\which.exe
bash&#x0D;&#x0A;if errorlevel 1 set
PATH=%SystemDrive%\cygwin\bin;%PATH%&#x0D;&#x0A;cmd /c&#x0D;&#x0A;if exist
&quot;$(WebKitOutputDir)\buildfailed&quot; grep XX$(ProjectName)XX
&quot;$(WebKitOutputDir)\buildfailed&quot;&#x0D;&#x0A;if errorlevel 1 exit
1&#x0D;&#x0A;echo XX$(ProjectName)XX &gt;
&quot;$(WebKitOutputDir)\buildfailed&quot;&#x0D;&#x0A;"
> +	/>

We should move the Apple-specific stuff out of InjectedBundleCommon so that the
non-Apple-specific things don't need to be duplicated here.