[webkit-reviews] review granted: [Bug 46305] Stub out a PluginProcessManager class : [Attachment 68435] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 46305: Stub out a PluginProcessManager class
https://bugs.webkit.org/show_bug.cgi?id=46305

Attachment 68435: Patch
https://bugs.webkit.org/attachment.cgi?id=68435&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68435&action=review

What about WebKit2.vcproj?

> WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:56
> +void PluginProcessManager::removePluginProcessProxy(PluginProcessProxy*
pluginProcessProxy)
> +{
> +    size_t vectorIndex = m_pluginProcesses.find(pluginProcessProxy);
> +    ASSERT(vectorIndex != notFound);
> +
> +    m_pluginProcesses.remove(vectorIndex);
> +}

Maybe a HashSet would be better?

> WebKit2/UIProcess/WebProcessProxy.h:97
> +    WebContext* context() const { return m_context; }

I don't see any callers of this function. It seems strange to add it in this
patch if it won't be used until a future patch.