[webkit-reviews] review granted: [Bug 46298] Add logicalWidth/Height getters and setters to RenderBox : [Attachment 68428] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 46298: Add logicalWidth/Height getters and setters to RenderBox
https://bugs.webkit.org/show_bug.cgi?id=46298

Attachment 68428: Patch
https://bugs.webkit.org/attachment.cgi?id=68428&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=68428&action=review

> WebCore/rendering/RenderBox.cpp:90
> +    if (style()->isVerticalBlockFlow())
> +	   return width();
> +    return height();

Maybe now it’s too late to say this, but how about
return style()->isVerticalBlockFlow() ? width() : height();
instead?