[webkit-reviews] review requested: [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text : [Attachment 68427] Single patch for fixing this bug + Unit test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25898: [Gtk] object:text-changed events should be emitted for entries and
password text
https://bugs.webkit.org/show_bug.cgi?id=25898

Attachment 68427: Single patch for fixing this bug + Unit test
https://bugs.webkit.org/attachment.cgi?id=68427&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #91)
> (From update of attachment 68346 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=68346&action=review
> 
> On further consideration, I'm pretty nervous that this does not hava test
attached to it? Is it possible to write one?

Attaching a new patch with a new unit case in testatk.c to check this works as
expected.

> > WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:73
> > +	 GOwnPtr<gchar> detail;
> > +	 switch (textChange) {
> > +	 case AXObjectCache::AXTextInserted:
> > +	     detail.set(g_strdup("text-changed::insert"));
> > +	     break;
> > +	 case AXObjectCache::AXTextDeleted:
> > +	     detail.set(g_strdup("text-changed::delete"));
> > +	     break;
> > +	 }
> 
> Please use CString here. Sorry I didn't notice this before.

No problem. Done.

Let's see this time... :-)