[webkit-reviews] review denied: [Bug 46284] [GTK] Replace instances of g_timeout_add() with g_idle_add() in testatk.c : [Attachment 68419] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 22 12:45:10 PDT 2010


Martin Robinson <mrobinson at webkit.org> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 46284: [GTK] Replace instances of g_timeout_add() with g_idle_add() in
testatk.c
https://bugs.webkit.org/show_bug.cgi?id=46284

Attachment 68419: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=68419&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68419&action=review

> WebKit/gtk/ChangeLog:8
> +	   Use g_idle_add() whenever g_timeout_add() was being used

You should explain here why this conversion is a good thing. In the future,
other programmers will see this commit and wonder what the explanation was. We
should be able to concisely describe to people why we prefer this style.


More information about the webkit-reviews mailing list