[webkit-reviews] review granted: [Bug 45957] Pixel test fast/multicol/column-rules-stacking.html regression : [Attachment 68409] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 45957: Pixel test fast/multicol/column-rules-stacking.html regression
https://bugs.webkit.org/show_bug.cgi?id=45957

Attachment 68409: Patch
https://bugs.webkit.org/attachment.cgi?id=68409&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68409&action=review

Which return clause in checkContainingBlockChainForPagination() does this
layout test exercise? If necessary, we should have tests for both.

> WebCore/rendering/RenderLayer.cpp:471
> +static bool checkContainingBlockChainForPagination(RenderBoxModelObject*
renderer, RenderBox* columnsRenderer)

It's hard to wrap my brain around which of these is a descendant of the other.
A comment would help.

> WebCore/rendering/RenderLayer.cpp:486
> +    // If the previous block is absolutely positioned, then we can't be
paginated by the columns block.
> +    if (prevBlock->isPositioned())

Just absolutely positioned, or relatively positioned too?