[webkit-reviews] review granted: [Bug 45681] Assertion failure: m_isValid == validity()->valid() after manipulating a detached element : [Attachment 67754] Patch 2 (resolve redundant setNeedsValidityCheck())

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 22 10:46:31 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 45681: Assertion failure: m_isValid == validity()->valid() after
manipulating a detached element
https://bugs.webkit.org/show_bug.cgi?id=45681

Attachment 67754: Patch 2 (resolve redundant setNeedsValidityCheck())
https://bugs.webkit.org/attachment.cgi?id=67754&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
OK. So, do you prefer the old or the new patch yourself? Given that you kept
the new one for review, I guess that's it, so I'll mark it r+.

> ta.checkValidity(); // This made an assertion failure.

"This made an assertion fail".


More information about the webkit-reviews mailing list