[webkit-reviews] review granted: [Bug 46220] Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release : [Attachment 68312] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 46220: Fix some Objective-C GC problems and use RetainPtr instead of
HardRetain/Release
https://bugs.webkit.org/show_bug.cgi?id=46220

Attachment 68312: Patch
https://bugs.webkit.org/attachment.cgi?id=68312&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68312&action=review

> WebCore/bindings/objc/ObjCEventListener.h:59
> +	   typedef id <DOMEventListener> ObjCListener;

There shouldn't be a space after id here.

> WebCore/bridge/objc/objc_instance.mm:88
> +    s_exception = nil;

How will not retaining here work in a non-GC environment?