[webkit-reviews] review canceled: [Bug 45589] Inline UTF8SequenceLength : [Attachment 68003] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 22 09:14:10 PDT 2010


Patrick R. Gansterer <paroga at paroga.com> has canceled Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 45589: Inline UTF8SequenceLength
https://bugs.webkit.org/show_bug.cgi?id=45589

Attachment 68003: Patch
https://bugs.webkit.org/attachment.cgi?id=68003&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #9)
> Sorry to keep pushing on this, but did you try just calling the inline
version as-is rather than merging them? I’d expect an even-better speed
improvement if you just changed the call site in convertUTF8ToUTF16 and didn’t
make the other changes.
I don't know why, but you're right! It's faster with the newest patch.


More information about the webkit-reviews mailing list