[webkit-reviews] review granted: [Bug 46086] Web Inspector: implement pausing on XHR : [Attachment 68362] Proposed patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 46086: Web Inspector: implement pausing on XHR
https://bugs.webkit.org/show_bug.cgi?id=46086

Attachment 68362: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=68362&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68362&action=review

> WebCore/inspector/InspectorController.cpp:156
> +unsigned InspectorController::s_inspectorControllerCount = 0;

I don't see it incrementing.

> WebCore/inspector/InspectorController.cpp:1683
> +	   RefPtr<InspectorObject> condition =
breakpoint->getObject("condition");

Nit: condition should be optional.

> WebCore/inspector/InspectorController.cpp:1687
> +	   if (!condition->getString("url", &url))

Same here, just stop on any.

> WebCore/inspector/InspectorController.h:492
> +inline InspectorController*
InspectorController::inspectorControllerForDocument(Document* document)

It is worth checking counter here.