[webkit-reviews] review granted: [Bug 46244] [GTK] Fix transfer annotations for WebKitGTK+ static API : [Attachment 68342] annotations.diff
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 22 07:30:24 PDT 2010
Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 46244: [GTK] Fix transfer annotations for WebKitGTK+ static API
https://bugs.webkit.org/show_bug.cgi?id=46244
Attachment 68342: annotations.diff
https://bugs.webkit.org/attachment.cgi?id=68342&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68342&action=review
Okay!
> WebKit/gtk/webkit/webkitwebdatasource.cpp:204
> + * not be freed or destroyed. This will return %NULL of the
Could you please fix the typo before landing?
> WebKit/gtk/webkit/webkitwebview.cpp:3651
> + * Return value: (transfer none): the main #WebKitWebFrame for @webView, or
%NULL
Might want to say what cases it returns NULL in.
More information about the webkit-reviews
mailing list