[webkit-reviews] review denied: [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text : [Attachment 68346] Single patch for fixing this bug

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 25898: [Gtk] object:text-changed events should be emitted for entries and
password text
https://bugs.webkit.org/show_bug.cgi?id=25898

Attachment 68346: Single patch for fixing this bug
https://bugs.webkit.org/attachment.cgi?id=68346&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68346&action=review

On further consideration, I'm pretty nervous that this does not hava test
attached to it? Is it possible to write one?

> WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:73
> +    GOwnPtr<gchar> detail;
> +    switch (textChange) {
> +    case AXObjectCache::AXTextInserted:
> +	   detail.set(g_strdup("text-changed::insert"));
> +	   break;
> +    case AXObjectCache::AXTextDeleted:
> +	   detail.set(g_strdup("text-changed::delete"));
> +	   break;
> +    }

Please use CString here. Sorry I didn't notice this before.