[webkit-reviews] review requested: [Bug 45375] [Regression][Gtk] Left and Right Arrows no longer function when caret browsing is enabled : [Attachment 68353] Patch to fix this issue + Layout test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 45375: [Regression][Gtk] Left and Right Arrows no longer function when
caret browsing is enabled
https://bugs.webkit.org/show_bug.cgi?id=45375

Attachment 68353: Patch to fix this issue + Layout test
https://bugs.webkit.org/attachment.cgi?id=68353&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #5)
> (From update of attachment 68251 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=68251&action=review
> 
> what about supporting more than word? i thought there was also line, page
(maybe sentence) options available as well

Good point. In this new patch I added support for
MoveTo{Beginning|End}Of{Line|Sentence|Paragraph}, and as far as I could check,
it was a nice addition. Thanks for pointing it out.

Also, extended the Layout test to check that new feature.

> > WebCore/ChangeLog:9
> > +
> 
> is the patch considering doing something or doing something?
> also end the sentence in a period

Done

On top of that, I've moved the tests from platform/gtk/accessibility to
platform/gtk/editing/selection since those are not really a11y tests at all
(just got confused because my work is usually a11y centered), and renamed them
accordingly since they're no longer about left and right arrows, but also about
home/end keys, for instance.