[webkit-reviews] review denied: [Bug 38381] [Windows] Implement <input type=number> UI : [Attachment 61177] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 38381: [Windows] Implement <input type=number> UI
https://bugs.webkit.org/show_bug.cgi?id=38381

Attachment 61177: Patch
https://bugs.webkit.org/attachment.cgi?id=61177&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=61177&action=review

mostly minor comments

> WebCore/rendering/RenderThemeWin.cpp:98
> +// Spin button staes

states spelled incorrectly

> WebCore/rendering/RenderThemeWin.cpp:500
> +}

extra new line that's not needed

> WebCore/rendering/RenderThemeWin.cpp:516
> +	       result.m_state = determineClassicState(o, false);

instead of using a bool here, a simple ENUM would be helpful so that when
looking at lines like this, it's clear that you're passing in a down button

> WebCore/rendering/RenderThemeWin.cpp:680
> +	   width = 17; // Vista's default.

can you retrieve this from some system setting if it's a default?

> WebCore/rendering/RenderThemeWin.cpp:688
> +	   return false;

why less than 2 and not 1 or 3?