[webkit-reviews] review requested: [Bug 39136] sheriffbot can't roll out security patches : [Attachment 68336] Patch with unit test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 21:15:35 PDT 2010


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 39136: sheriffbot can't roll out security patches
https://bugs.webkit.org/show_bug.cgi?id=39136

Attachment 68336: Patch with unit test
https://bugs.webkit.org/attachment.cgi?id=68336&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Updated patch as <https://bugs.webkit.org/attachment.cgi?id=67642> became
stale.

Also fixed style issue:
"WebKitTools/Scripts/webkitpy/tool/steps/preparechangelog.py:58:  at least two
spaces before inline comment"
After talking with Eric, decided to use has_key as the BeautifulSoup element
object is not a native dictionary.


More information about the webkit-reviews mailing list