[webkit-reviews] review denied: [Bug 46239] [chromium] Check if the acceleratedCompositingEnabled setting is active in WebViewImpl::graphicsContext3D() : [Attachment 68325] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 19:00:03 PDT 2010


Kenneth Russell <kbr at google.com> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 46239: [chromium] Check if the acceleratedCompositingEnabled setting is
active in WebViewImpl::graphicsContext3D()
https://bugs.webkit.org/show_bug.cgi?id=46239

Attachment 68325: Patch
https://bugs.webkit.org/attachment.cgi?id=68325&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
If I'm reading the diff correctly, you're missing a return statement if
accelerated compositing isn't enabled for the page. The patch looks good
otherwise, but r- for this serious issue.


More information about the webkit-reviews mailing list