[webkit-reviews] review granted: [Bug 46232] Extending the selection to sentence boundary after a line break may select extra character : [Attachment 68309] Advance the text iterator instead of advancing a position
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 21 17:04:33 PDT 2010
Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 46232: Extending the selection to sentence boundary after a line break may
select extra character
https://bugs.webkit.org/show_bug.cgi?id=46232
Attachment 68309: Advance the text iterator instead of advancing a position
https://bugs.webkit.org/attachment.cgi?id=68309&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68309&action=review
> WebCore/editing/visible_units.cpp:234
> + characterRange = charIt.range();
> + pos = characterRange->startPosition();
Why not just write charIt.range()->startPosition()?
More information about the webkit-reviews
mailing list