[webkit-reviews] review granted: [Bug 46128] webkitpy - display web pages using a common routine : [Attachment 68275] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 46128: webkitpy - display web pages using a common routine
https://bugs.webkit.org/show_bug.cgi?id=46128

Attachment 68275: Patch
https://bugs.webkit.org/attachment.cgi?id=68275&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68275&action=review

This looks good.  I'm sorry that I don't have time to review it in complete
detail, but this looks like a good compromise for now.

> WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:90
> +	   self._name = kwargs.get('port_name', None)
> +	   self._options = kwargs.get('options', None)
> +	   self._executive = kwargs.get('executive', Executive())
> +	   self._user = kwargs.get('user', User())

You can just name these in the argument list and let **kwargs grab the rest.