[webkit-reviews] review denied: [Bug 44920] Add layout tests for FileSystem API : [Attachment 67987] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 44920: Add layout tests for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=44920

Attachment 67987: Patch
https://bugs.webkit.org/attachment.cgi?id=67987&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=67987&action=review

All the results generally look like "8" is "8"... can these have a little more
context in them. right now they're impossible for a human to parse

tests should be as such

shouldBe("controller.operation.result", "true");

so the results are understandable when something breaks

> LayoutTests/fast/filesystem/script-tests/simple-persistent.js:13
> +    shouldBeTrue("true");

this looks meaningless

> LayoutTests/fast/filesystem/simple-temporary-expected.txt:7
> +WARN: shouldBe() expects string arguments

this looks wrong