[webkit-reviews] review denied: [Bug 45381] [Gtk] Adjust atk_text_get_text_at_offset to account for bullets/numbers in list items : [Attachment 67808] Patch proposal

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 45381: [Gtk] Adjust atk_text_get_text_at_offset to account for
bullets/numbers in list items
https://bugs.webkit.org/show_bug.cgi?id=45381

Attachment 67808: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=67808&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=67808&action=review

i don't know how other people feel about adding a variable to RenderListMarker.
sometimes they are quite picky about that. 

need a layout test for this however

> WebCore/ChangeLog:39
> +

indent comments when they are underneath the a filename. it makes it easier to
read

> WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:1218
> +    RenderObject* renderer = static_cast<const
AccessibilityRenderObject*>(object)->renderer();

check if renderer is nil as well

> WebCore/rendering/RenderListItem.cpp:325
> +    const String& markerTxt = m_marker->text();

var name should be markerText