[webkit-reviews] review requested: [Bug 45383] [Gtk] Incorrect exposure of list items whose children are elements : [Attachment 68289] Patch proposal
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 21 14:09:43 PDT 2010
Mario Sanchez Prada <msanchez at igalia.com> has asked for review:
Bug 45383: [Gtk] Incorrect exposure of list items whose children are elements
https://bugs.webkit.org/show_bug.cgi?id=45383
Attachment 68289: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=68289&action=review
------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #9)
> (From update of attachment 68261 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=68261&action=review
>
> > WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:2038
> > + if (children.size() > 0) {
>
> sorry...
>
> this should just be
> if (children.size())
No problem. Attaching a new patch with that issue fixed.
More information about the webkit-reviews
mailing list